This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Eliminate location wrappers in tree_nop_conversion/STRIP_NOPS
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>, Jason Merrill <jason at redhat dot com>
- Cc: Nathan Sidwell <nathan at acm dot org>, Richard Biener <richard dot guenther at gmail dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 Dec 2017 21:27:09 -0700
- Subject: Re: [PATCH] Eliminate location wrappers in tree_nop_conversion/STRIP_NOPS
- Authentication-results: sourceware.org; auth=none
- References: <20171219220321.GD2353@tucnak> <1513730678-53275-1-git-send-email-dmalcolm@redhat.com>
On 12/19/2017 05:44 PM, David Malcolm wrote:
> On Tue, 2017-12-19 at 23:03 +0100, Jakub Jelinek wrote:
>> On Tue, Dec 19, 2017 at 04:59:34PM -0500, Jason Merrill wrote:
>>>> Or do you mean it should strip just the special VIEW_CONVERT_EXPR
>>>> that has type identical to the operand's type?
>>>
>>> That; interpreting something as the same type seems like a nop.
>>
>> Ok, that makes sense.
>>
>> Jakub
>
> Thanks.
>
> How does the following look?
>
> Bootstrap®rtest in progress; OK for trunk if it passes? (once the rest of
> the kit is approved, of course)
>
> gcc/ChangeLog:
> * tree.c (tree_nop_conversion): Return true for location wrapper
> nodes.
> (selftest::check_strip_nops): New function.
> (selftest::test_location_wrappers): Verify that STRIP_NOPS removes
> wrappers.
OK.
jeff