This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Jeff Law <law at redhat dot com>
- Date: Mon, 11 Dec 2017 11:45:25 +0100
- Subject: Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p
- Authentication-results: sourceware.org; auth=none
- References: <20171206193659.GI2353@tucnak>
> When looking at the rs6000_store_data_bypass_p stuff, I've noticed that
> it accepts PARALLELs containing not just SETs and CLOBBERs like
> store_data_bypass_p, but also USEs. Given that it is something that
> single_set also ignores, I think fixing store_data_bypass_p is the
> right fix here.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> Note, the patch is larger due to the formatting fixes, the actual changes
> are just 3x
> - if (GET_CODE (xxx) == CLOBBER)
> + if (GET_CODE (xxx) == CLOBBER || GET_CODE (xxx) == USE)
Couldn't the code be also re-factored? Because 3x the same change is a lot...
> 2017-12-06 Jakub Jelinek <jakub@redhat.com>
>
> * recog.c (store_data_bypass_p): Handle USE in a PARALLEL
> like CLOBBER. Formatting fixes.
OK for mainline modulo the above remark.
--
Eric Botcazou