This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [pr#83069] Keep profile_count for bb under real_bb_freq_max
- From: Jeff Law <law at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, gcc-patches at gcc dot gnu dot org
- Cc: hubicka at gcc dot gnu dot org
- Date: Tue, 5 Dec 2017 13:10:02 -0700
- Subject: Re: [PATCH] [pr#83069] Keep profile_count for bb under real_bb_freq_max
- Authentication-results: sourceware.org; auth=none
- References: <1511525181-25726-1-git-send-email-siddhesh@gotplt.org> <92763fbb-ece2-ced8-0214-8c97f4dcc508@gotplt.org>
On 11/28/2017 04:34 AM, Siddhesh Poyarekar wrote:
> On Friday 24 November 2017 05:36 PM, Siddhesh Poyarekar wrote:
>> freq_max < 1, i.e. highest frequency among bbs in the function being
>> higher than real_bb_freq_max means that the bb ends up with a profile
>> count larger than real_bb_freq_max and then can go all the way up to
>> and beyond profile_count::max_count.
>>
>> Bootstrapped on aarch64, testsuite in progress.
>
> Tests came out clean (no new regressions) on aarch64 and x86_64. Ping?
>
> Siddhesh
>
>>
>> * gcc/predict.c (estimate_bb_frequencies): Don't reset freq_max.
>> * gcc/testsuite/gcc.dg/pr83069.c: New test case.
Just a note. Honza indicated in the associated BZ that he was going to
prepare an alternate patch to address this problem.
Jeff