This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64
- From: Steve Ellcey <sellcey at cavium dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Mon, 04 Dec 2017 16:51:35 -0800
- Subject: Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <59A54F1C.3010806@arm.com> <1504200277.3182.22.camel@cavium.com> <59CCDD8A.9020703@arm.com> <1506716977.15649.41.camel@cavium.com> <59D24F48.4060906@arm.com> <1507057058.15649.72.camel@cavium.com> <1508868696.19854.53.camel@cavium.com> <1511199565.16234.4.camel@cavium.com> <20171120182659.GA10897@arm.com> <1511205735.16234.10.camel@cavium.com> <20171121173517.GA18058@arm.com> <1511914363.10128.39.camel@cavium.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
FYI: Since James approved the Aarch64 part and since I think the
generic part can be considered trivial, I have gone ahead and checked
this patch in.
Steve Ellcey
sellcey@cavium.com
On Tue, 2017-11-28 at 16:12 -0800, Steve Ellcey wrote:
> On Tue, 2017-11-21 at 17:35 +0000, James Greenhalgh wrote:
>
> >
> >
> > Thanks for the detailed explanation. I understood this, and my
> > opinion is
> > that the AArch64 parts of this patch are OK (and I don't know who
> > needs to
> > Ack the small generic changes you require).
> >
> > Let's give Richard/Marcus 48 hours to object while we wait for an
> > OK on the
> > generic bits, and then OK for AArch64.
> >
> > Thanks,
> > James
> >
> > Reviewed-By: James Greenhalgh <james.greenhalgh@arm.com>
> James, I haven't seen anything from Richard or Marcus. Do you think
> a
> review from a global maintainer is really needed? There is no
> libatomic specific maintainer. The only non-aarch64 specific change
> is using the macro IFUNC_RESOLVER_ARGS in place of the hardcoded
> 'void'
> argument for ifunc selector functions and for all non-aarch64
> platforms
> the macro will be defined as 'void' so there is no real change for
> any
> other platform.
>
> Steve Ellcey
> sellcey@cavium.com