This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][aarch64] Add missing thunderx2-t99 instruction scheduling pipeline descriptions.
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, James Greenhalgh <James dot Greenhalgh at arm dot com>
- Date: Mon, 04 Dec 2017 09:33:37 -0800
- Subject: Re: [Patch][aarch64] Add missing thunderx2-t99 instruction scheduling pipeline descriptions.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1512153744.14842.3.camel@cavium.com> <5A258369.4090109@foss.arm.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, 2017-12-04 at 17:18 +0000, Kyrill Tkachov wrote:
> > +(define_insn_reservation "thunderx2t99_multiple" 1
> > + (and (eq_attr "tune" "thunderx2t99")
> > + (eq_attr "type" "multiple"))
> > + "thunderx2t99_i0+thunderx2t99_i1+thunderx2t99_i2+thunderx2t99_ls
> > 0+thunderx2t99_ls1+thunderx2t99_sd+thunderx2t99_i1m1+thunderx2t99_i
> > 1m2+thunderx2t99_i1m3+thunderx2t99_ls0d1+thunderx2t99_ls0d2+thunder
> > x2t99_ls0d3+thunderx2t99_ls1d1+thunderx2t99_ls1d2+thunderx2t99_ls1d
> > 3+thunderx2t99_f0+thunderx2t99_f1")
> > +
> We try to adhere to the 80 columns per line rule in the scheduling
> description files as well,
> so can you please use "\" to break this into multiple lines.
Yes, I wasn't sure if whatever program parses this file would honor
backslashes so I didn't break it up. The falkor_extra definition in
falkor.md that I looked at is more than 80 characters and that is one
of the reasons I wasn't sure backslashes would be honored. But I see
other places (power8.md) where the backslashes are used so I will make
that change if and when the patch is approved.
Steve Ellcey
sellcey@cavium.com