This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][ARM] Dot Product NEON intrinsics [Patch (3/8)]
- From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- To: Tamar Christina <Tamar dot Christina at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "nickc at redhat dot com" <nickc at redhat dot com>
- Date: Wed, 22 Nov 2017 11:26:37 +0000
- Subject: Re: [PATCH][GCC][ARM] Dot Product NEON intrinsics [Patch (3/8)]
- Authentication-results: sourceware.org; auth=none
- References: <20171106165336.GA12409@arm.com>
Hi Tamar,
On 06/11/17 16:53, Tamar Christina wrote:
Hi All,
This patch adds the NEON intrinsics for Dot product.
Dot product is available from ARMv8.2-a and onwards.
Regtested on arm-none-eabi, armeb-none-eabi,
aarch64-none-elf and aarch64_be-none-elf with no issues found.
Ok for trunk?
gcc/
2017-11-06 Tamar Christina <tamar.christina@arm.com>
* config/aarch64/arm_neon.h (vdot_u32, vdotq_u32)
This should be config/arm/arm_neon.h
(vdot_s32, vdotq_s32): New.
(vdot_lane_u32, vdotq_lane_u32): New.
(vdot_lane_s32, vdotq_lane_s32): New.
gcc/testsuite/
2017-11-06 Tamar Christina <tamar.christina@arm.com>
* gcc.target/arm/simd/vdot-compile.c: New.
* gcc.target/arm/simd/vect-dot-qi.h: New.
* gcc.target/arm/simd/vect-dot-s8.c: New.
* gcc.target/arm/simd/vect-dot-u8.c: New
--
diff --git a/gcc/config/arm/arm_neon.h b/gcc/config/arm/arm_neon.h
index 0d436e83d0f01f0c86f8d6a25f84466c841c7e11..419080417901f343737741e334cbff818bb1e70a 100644
--- a/gcc/config/arm/arm_neon.h
+++ b/gcc/config/arm/arm_neon.h
@@ -18034,6 +18034,72 @@ vzipq_f16 (float16x8_t __a, float16x8_t __b)
#endif
+/* Adv.SIMD Dot Product intrinsics. */
Please no full stop: "AdvSIMD".
+
+#pragma GCC push_options
+#if __ARM_ARCH >= 8
+#pragma GCC target ("arch=armv8.2-a+dotprod")
<snip>
diff --git a/gcc/testsuite/gcc.target/arm/simd/vect-dot-qi.h b/gcc/testsuite/gcc.target/arm/simd/vect-dot-qi.h
new file mode 100644
index 0000000000000000000000000000000000000000..90b00aff95cfef96d1963be17673dc191cc71169
--- /dev/null
+++ b/gcc/testsuite/gcc.target/arm/simd/vect-dot-qi.h
@@ -0,0 +1,15 @@
+TYPE char X[N] __attribute__ ((__aligned__(__BIGGEST_ALIGNMENT__)));
+TYPE char Y[N] __attribute__ ((__aligned__(__BIGGEST_ALIGNMENT__)));
+
+__attribute__ ((noinline)) int
+foo1(int len) {
+ int i;
+ TYPE int result = 0;
+ TYPE short prod;
+
+ for (i=0; i<len; i++) {
+ prod = X[i] * Y[i];
+ result += prod;
+ }
+ return result;
+}
\ No newline at end of file
Please add new lines at the end of the new test files.
This applies to a few more new files in this patch.
Ok with these nits fixed.
Thanks,
Kyrill