This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix mult expansion ICE (PR middle-end/82875)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Richard Sandiford <richard dot sandiford at linaro dot org>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 22 Nov 2017 10:55:23 +0100
- Subject: Re: [PATCH] Fix mult expansion ICE (PR middle-end/82875)
- Authentication-results: sourceware.org; auth=none
- References: <20171122091718.GH14653@tucnak> <alpine.LSU.2.20.1711221039260.12252@zhemvz.fhfr.qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 22, 2017 at 10:41:19AM +0100, Richard Biener wrote:
> How much churn would it be to pass down a mode alongside the operands
> in expand_binop? Can't find it right now but didn't we introduce
> some rtx_with_mode pair-like stuff somewhen?
We have rtx_mode_t for that. But there are 240+ calls to expand_binop,
and even if we add an overload that will transform it, unless we forcefully
inline it wouldn't that slow down all the spots a little bit?
The thing is, for the vast majority of binary ops we don't need the operand
modes, it is mainly comparisons, second arg of shifts/rotates and this
widening case.
Jakub