This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Ian Lance Taylor <iant at golang dot org>
- Cc: gcc-patches at gcc dot gnu dot org, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>
- Date: Tue, 21 Nov 2017 20:53:50 +0100
- Subject: Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH
- Authentication-results: sourceware.org; auth=none
- References: <CAOyqgcVrpOM4-7GMmGere0UTqmxSmeHAvWMKeMb+X3H1H48Q_w@mail.gmail.com>
> This patch by Than McIntosh fixes a small bug in the libgo Makefile
> recipe that constructs the directory from which to pick up
> libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was
> missing the flags, which meant that for -m32 builds we'd see the
> 64-bit libgcc dir. Bootstrapped and ran Go testsuite on
> x86_64-pc-linux-gnu. Committed to mainline.
Thanks, this helps on Solaris. I have attached another fixlet: the -q option
of grep is rejected on Solaris. Tested on Linux and Solaris.
--
Eric Botcazou
Index: mksigtab.sh
===================================================================
--- mksigtab.sh (revision 255000)
+++ mksigtab.sh (working copy)
@@ -29,7 +29,7 @@ addsig() {
echo " $1: $2,"
# Get the signal number and add it to SIGLIST
signum=`grep "const $1 = " gen-sysinfo.go | sed -e 's/.* = //'`
- if echo "$signum" | grep -q '^_SIG[A-Z0-9_]*$'; then
+ if echo "$signum" | grep '^_SIG[A-Z0-9_]*$' >/dev/null 2>&1; then
# Recurse once to obtain signal number
# This is needed for some MIPS signals defined as aliases of other signals
signum=`grep "const $signum = " gen-sysinfo.go | sed -e 's/.* = //'`