This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping
- From: Jim Wilson <jimw at sifive dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Jason Merrill <jason at redhat dot com>, Nathan Sidwell <nathan at acm dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 20 Nov 2017 18:46:23 -0800
- Subject: Re: Patch ping
- Authentication-results: sourceware.org; auth=none
- References: <20171120075512.GE14653@tucnak> <7faf2079-f3d2-2b9c-5d08-107cad3eb859@sifive.com>
On 11/20/2017 02:58 PM, Jim Wilson wrote:
The dwarf2out.c patch looks good to me, though the testcase does not
fail on unpatched mainline anymore. I had to go back to the 2017-10-22
snapshot to see the failure. There was a followup from Mark Wielaard
mentioning that elfutils still fails on mainline, so maybe we can get a
testcase from there.
The testcase was "broken" by Jan's big patch on Nov 3
https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00104.html
It didn't seem useful to look into that, so I tried running
multidelta/creduce on the elfutils sources, and managed to get a small
testcase that still fails with mainline. I then fixed it to get rid of
the warnings.
#include <stdlib.h>
extern int c (void);
int
a(int b) {
if (c())
abort();
}
There is no guarantee that this testcase will still show the problem in
the future, but it seems good enough for now.
OK with this testcase. And with your testcase too if you think that
still has value.
Jim