This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597
- From: Michael Collison <Michael dot Collison at arm dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Richard Biener <richard dot guenther at gmail dot com>
- Date: Mon, 20 Nov 2017 06:23:39 +0000
- Subject: Re: [PING][PATCH][compare-elim] Fix PR rtl-optimization/82597
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Michael dot Collison at arm dot com;
- Nodisclaimer: True
- References: <HE1PR0802MB2377CE352B3D4430B0DDA40695450@HE1PR0802MB2377.eurprd08.prod.outlook.com>,<52747d16-a922-1d55-cbf4-634d54b298e5@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Jeff,
No longer needed. Jakub's patch does the job.
Michael Collison
> On Nov 19, 2017, at 3:50 PM, Jeff Law <law@redhat.com> wrote:
>
>> On 10/25/2017 11:54 PM, Michael Collison wrote:
>> Ping. Original patch posted here:
>>
>> https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01317.html
> Is this still needed or was it addressed by the patch Jakub checked in here:
>
>
>
> 2017-11-01 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/82778
> PR rtl-optimization/82597
> * compare-elim.c (struct comparison): Add in_a_setter field.
> (find_comparison_dom_walker::before_dom_children): Remove killed
> bitmap and df_simulate_find_defs call, instead walk the defs.
> Compute last_setter and initialize in_a_setter. Merge definitions
> with first initialization for a few variables.
> (try_validate_parallel): Use insn_invalid_p instead of
> recog_memoized. Return insn rather than just the pattern.
> (try_merge_compare): Fix up comment. Don't uselessly test if
> in_a is a REG_P. Use cmp->in_a_setter instead of walking UD
> chains.
> (execute_compare_elim_after_reload): Remove df_chain_add_problem
> call.