This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fixes for PR68356, PR81210, and PR81693


On Nov 12, 2017, at 6:58 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> 
> On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières
> <dominiq@lps.ens.fr> wrote:
>> The following patch fixes PR68356, PR81210, and PR81693 on darwin.
>> 
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68264.c    2016-01-28 00:30:03.000000000 +0100
>> +++ gcc/testsuite/gcc.dg/torture/pr68264.c      2017-11-11 17:16:58.000000000 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run } */
>> +/* { dg-xfail-run-if "PR68356 no math-errno on darwin" { "*-*-darwin*" } } */
>> /* { dg-add-options ieee } */
>> /* { dg-require-effective-target fenv_exceptions } */
>> 
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-1.c  2016-06-10 15:22:50.000000000 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr68037-1.c    2017-11-11 18:43:16.000000000 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>> 
>> extern void exit (int);
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-2.c  2016-06-10 15:22:50.000000000 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr68037-2.c    2017-11-11 18:44:08.000000000 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>> 
>> extern void exit (int);
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-3.c  2016-06-10 15:22:50.000000000 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr68037-3.c    2017-11-11 18:49:10.000000000 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } { "-O1" "-O2" "-O3" "-Os" } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>> 
>> #include <stddef.h>
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-1.c  2017-10-26 07:16:19.000000000 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr25967-1.c    2017-11-11 19:36:30.000000000 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81693" { "*-*-darwin*" } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>> 
>> extern void exit (int);
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-2.c  2017-10-26 07:16:19.000000000 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr25967-2.c    2017-11-11 19:36:02.000000000 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81693" { *-*-darwin* && ilp32 } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>> 
>> 
>> Is it OK?
> 
> I wrote these tests.  These tests don't align stack to 16 bytes and
> should be skipped on Darwin.

So, sounds like something based on:

  /* { dg-skip-if "sp not aligned to 16 bytes" { *-*-darwin } } */

then.  Ok with that change.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]