This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA][PATCH] 2/n Refactoring tree-vrp.c -- pull evrp bits into their own file




On 11/10/2017 09:11 AM, Richard Biener wrote:
On Fri, Nov 10, 2017 at 1:30 AM, Jeff Law <law@redhat.com> wrote:
This patch pulls out the EVRP class & methods from tree-vrp.c.  It's a
straight copy-n-paste with the exception of the evrp_folder class which
I trimmed back down to its minimal form.

This obviously forces shared structures/routines between tree-vrp.c and
tree-evrp.c to get exposed in a header file (tree-vrp.h).  I consider
this a positive as those dependencies are now fairly explicit and we can
work to rationalize that set (ie, does the dependency make sense, where
is the most natural place for the shared bits, etc).

I'm not ready to pull the trigger on submission, but I fully expect
tree-evrp.c to go through another refactoring to separate analysis from
optimization -- which then allows us to embed the analysis bits into
other passes.

Bootstrapped and regression tested on x86_64.  OK for the trunk?

Ok, but can you name it gimple-ssa-evrp.c please? ;)

Yes, please do. Slowly but surely I'm becoming a global maintainer by wildcard ;-).

$ grep aldy ../MAINTAINERS
rs6000 vector extns     Aldy Hernandez          <aldyh@redhat.com>
*gimpl*                 Aldy Hernandez          <aldyh@redhat.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]