This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][ARM] Refactor arm_option_override to extract global field setters [Patch (1/3)]
- From: Tamar Christina <Tamar dot Christina at arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: nd <nd at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "nickc at redhat dot com" <nickc at redhat dot com>
- Date: Fri, 10 Nov 2017 17:11:38 +0000
- Subject: Re: [PATCH][GCC][ARM] Refactor arm_option_override to extract global field setters [Patch (1/3)]
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Tamar dot Christina at arm dot com;
- Nodisclaimer: True
- References: <20171106164803.GA11654@arm.com>,<5A02D7AD.2030907@foss.arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hi Kyrill,
Bootstrap on arm-none-linux-gnueabihf showed no issue, so I will commit the patch.
Thanks,
Tamar
________________________________________
From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Sent: Wednesday, November 8, 2017 10:08:45 AM
To: Tamar Christina; gcc-patches@gcc.gnu.org
Cc: nd; Ramana Radhakrishnan; Richard Earnshaw; nickc@redhat.com
Subject: Re: [PATCH][GCC][ARM] Refactor arm_option_override to extract global field setters [Patch (1/3)]
Hi Tamar,
On 06/11/17 16:48, Tamar Christina wrote:
> Hi All,
>
> This patch does a small refactoring to arm_option_override to extract the
> part that sets the global state variables so they can be changed without
> changing other global field that we do not want to change after the
> initial
> configuration has finished.
>
> Regtested on arm-none-eabi and no regressions.
>
Please also run a bootstrap and test on arm-none-linux-gnueabihf.
This is ok if that shows no problems.
Thanks,
Kyrill
> Ok for trunk?
>
> gcc/
> 2017-11-06 Tamar Christina <tamar.christina@arm.com>
>
> PR target/82641
> * config/arm/arm.c
> (arm_option_override): Refactor.
> (arm_option_reconfigure_globals): New.
> (arm_options_perform_arch_sanity_checks): New.
> * config/arm/arm-protos.h (arm_option_reconfigure_globals):
> New prototype.
> (arm_options_perform_arch_sanity_checks): Likewise
>
> --