This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AArch64] Tweak aarch64_classify_address interface
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: <gcc-patches at gcc dot gnu dot org>, <richard dot sandiford at linaro dot org>
- Cc: <nd at arm dot com>
- Date: Fri, 10 Nov 2017 15:16:47 +0000
- Subject: Re: [AArch64] Tweak aarch64_classify_address interface
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=arm.com;
- Nodisclaimer: True
- References: <8760dgc5wc.fsf@linaro.org> <20170830170056.GC30919@arm.com> <87val4m3rc.fsf@linaro.org> <87377kgm1d.fsf@linaro.org> <87tvypbvay.fsf@linaro.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, Oct 23, 2017 at 06:58:29PM +0100, Richard Sandiford wrote:
> Ping.
Makes sense. OK.
Reviewed-By: James Greenhalgh <james.greenhalgh@arm.com>
James
> Richard Sandiford <richard.sandiford@linaro.org> writes:
> > Richard Sandiford <richard.sandiford@linaro.org> writes:
> >> James Greenhalgh <james.greenhalgh@arm.com> writes:
> >>> On Tue, Aug 22, 2017 at 10:23:47AM +0100, Richard Sandiford wrote:
> >>>> Previously aarch64_classify_address used an rtx code to distinguish
> >>>> LDP/STP addresses from normal addresses; the code was PARALLEL
> >>>> to select LDP/STP and anything else to select normal addresses.
> >>>> This patch replaces that parameter with a dedicated enum.
> >>>>
> >>>> The SVE port will add another enum value that didn't map naturally
> >>>> to an rtx code.
> >>>>
> >>>> Tested on aarch64-linux-gnu. OK to install?
> >>>
> >>> I can't say I really like this new interface, I'd prefer two wrappers
> >>> aarch64_legitimate_address_p , aarch64_legitimate_ldp_address_p (or similar)
> >>> around your new interface, and for most code to simply call the wrapper.
> >>> Or an overloaded call that filled in ADDR_QUERY_M automatically, to save
> >>> that spreading through the backend.
> >>
> >> OK, I went for the second, putting the query type last and making it
> >> an optional argument.
> >
> > By way of a ping, here's the patch updated to current trunk.
> >
> > Tested on aarch64-linux-gnu. OK to install?
> >
> > Thanks,
> > Richard
> >
> > 2017-09-18 Richard Sandiford <richard.sandiford@linaro.org>
> > Alan Hayward <alan.hayward@arm.com>
> > David Sherwood <david.sherwood@arm.com>
> >
> > gcc/
> > * config/aarch64/aarch64-protos.h (aarch64_addr_query_type): New enum.
> > (aarch64_legitimate_address_p): Use it instead of an rtx code,
> > as an optional final parameter.
> > * config/aarch64/aarch64.c (aarch64_classify_address): Likewise.
> > (aarch64_legitimate_address_p): Likewise.
> > (aarch64_address_valid_for_prefetch_p): Update calls accordingly.
> > (aarch64_legitimate_address_hook_p): Likewise.
> > (aarch64_print_operand_address): Likewise.
> > (aarch64_address_cost): Likewise.
> > * config/aarch64/constraints.md (Umq, Ump): Likewise.
> > * config/aarch64/predicates.md (aarch64_mem_pair_operand): Likewise.
> >