This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Fix folding of vector mask EQ/NE expressions

From: Marc Glisse <marc dot glisse at inria dot fr>
To: Richard Sandiford <richard dot sandiford at linaro dot org>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 6 Nov 2017 20:19:58 +0100 (CET)
Subject: Re: Fix folding of vector mask EQ/NE expressions
Authentication-results: sourceware.org; auth=none
References: <87po8vwhpb.fsf@linaro.org>
Reply-to: gcc-patches at gcc dot gnu dot org

On Mon, 6 Nov 2017, Richard Sandiford wrote:

fold_binary_loc assumed that if the type of the result wasn't a vector,
the operands wouldn't be either.  This isn't necessarily true for
EQ_EXPR and NE_EXPR of vector masks, which can return a single scalar
for the mask as a whole.

Spell it VECTOR_TYPE_P? This looks clearly better, but that whole block ofcode smells like something that should disappear eventually...


--
Marc Glisse

Follow-Ups:
- Re: Fix folding of vector mask EQ/NE expressions
  - From: Richard Biener

References:
- Fix folding of vector mask EQ/NE expressions
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]