This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ping, Fortran, Patch, v1] Three small patches for character arrays
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Andre Vehreschild <vehre at gmx dot de>
- Cc: GCC-Patches-ML <gcc-patches at gcc dot gnu dot org>, GCC-Fortran-ML <fortran at gcc dot gnu dot org>
- Date: Sat, 4 Nov 2017 12:06:15 +0000
- Subject: Re: [Ping, Fortran, Patch, v1] Three small patches for character arrays
- Authentication-results: sourceware.org; auth=none
- References: <20171101122711.3026673d@vepi2> <20171104112722.149a4ef7@vepi2>
Hi Andre,
These patches look fine to me. Thanks for taking account of the array
descriptor change between trunk and 7-branch :-)
OK for trunk and 7-branch.
Thanks
Paul
On 4 November 2017 at 10:27, Andre Vehreschild <vehre@gmx.de> wrote:
> Ping!
>
> On Wed, 1 Nov 2017 12:27:11 +0100
> Andre Vehreschild <vehre@gmx.de> wrote:
>
>> Hi all,
>>
>> during development on OpenCoarrays I found these three issues in gfortran:
>>
>> - caf_send: Did not treat char arrays as arrays when calling caf_send.
>> - gfc_trans_assignment_1: Conversion of character kind creates a loop variant
>> temporary which must not be put before the loop body, but within.
>> - get_array_span: When doing pointer arithmetic on char arrays the character
>> kind was not applied.
>>
>> The attached patch fixes all of these issues for trunk and gcc-7. Bootstrapped
>> and regtested on x86_64-linux-gnu/f25. Ok for trunk and gcc-7?
>>
>> Regards,
>> Andre
>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein