Re: [PATCH, version 5a], Add support for _Float<N> and _Float<N>X sqrt, fma, fmin, fmax built-in functions

[Joseph Myers <joseph at codesourcery dot com>]

On Tue, 31 Oct 2017, Michael Meissner wrote:

> On Mon, Oct 30, 2017 at 11:30:12PM +0000, Joseph Myers wrote:
> > On Mon, 30 Oct 2017, Michael Meissner wrote:
> > 
> > > This patch fixes exporting the non __builtin_ names to be done by default only
> > > for the C language.  I added a target hook in case a port needs to enable
> > > built-ins for C++ (either wholesale, or for particular built-in functions).
> > 
> > Testing lang_GNU_C () can't possibly be correct here; ObjC should always 
> > be handled like C unless there is a strong reason not to do so, explicitly 
> > commented.
> > 
> > Also, I'd expect the FALLBACK_P argument to DEF_BUILTIN to be true, not a 
> > call to the hook; __builtin_sqrtf128 should always end up generating a 
> > call to the out-of-line sqrtf128 function if not inlined, regardless of 
> > source language.
> 
> This patch fixes both issues.  I have done bootstrap builds on both a little
> endian power8 and an x86-64 system with no regressions.  Can I check this into
> the trunk?

All the references to "enum builtin_in_function", in comments and 
documentation, should be "enum built_in_function".  OK with that change.

-- 
Joseph S. Myers
joseph@codesourcery.com