This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

From: Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
Date: Mon, 16 Oct 2017 14:45:28 +0300
Subject: Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
Authentication-results: sourceware.org; auth=none
References: <HE1PR0801MB2058E52BD74C5B0E786048A683720@HE1PR0801MB2058.eurprd08.prod.outlook.com> <DB6PR0801MB205351A8E84F80EB64D906B6834F0@DB6PR0801MB2053.eurprd08.prod.outlook.com>

> On Oct 16, 2017, at 1:56 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> 
> This patch cleans up autopref scheduling.
> 
> The code is greatly simplified.  Sort accesses on the offset first, and
> only if the offsets are the same fall back to other comparisons in
> rank_for_schedule.  This doesn't at all restore the original behaviour
> since we no longer compare the base address, but it now defines a total
> sorting order.  More work will be required to improve the sorting so
> that only loads/stores with the same base are affected.
> 
> AArch64 bootstrap completes.
> 
> OK for commit?

Looks good to me.  I'm not an official scheduler maintainer, so wait for an ack from a maintainer.

--
Maxim Kuvyrkov
www.linaro.org

References:
- [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Wilco Dijkstra
- [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]