This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

From: Alexander Monakov <amonakov at ispras dot ru>
To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
Cc: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, Christophe Lyon <christophe dot lyon at linaro dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, richard dot sandiford at linaro dot org
Date: Wed, 4 Oct 2017 16:39:29 +0300 (MSK)
Subject: Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
Authentication-results: sourceware.org; auth=none
References: <HE1PR0801MB2058E52BD74C5B0E786048A683720@HE1PR0801MB2058.eurprd08.prod.outlook.com> <CAKdteOZQ=5A+cb0aOS57ACD96MCdsO57rLk1DRah+G+4nZLstg@mail.gmail.com> <DB6PR0801MB20539186B7BAF4AE588EA04383730@DB6PR0801MB2053.eurprd08.prod.outlook.com> <87h8vftbvd.fsf@linaro.org> <CAJA7tRakoX069qZQdo1WSb4pUmgvwMLvucW4gbLk=tFdQsF9Lg@mail.gmail.com>

On Wed, 4 Oct 2017, Ramana Radhakrishnan wrote:
> However we need a scheduler maintainer or global reviewer to please
> help review this patch or help come up with an alternative patch. A
> primary platform broken for 5 days with a commit and no public
> response from the original poster is really not appropriate behaviour
> in this community. If not, the original patch should have been
> considered for reverting under the 48 hour rule .

I responded within 30 minutes of the original report by Christophe:
https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01984.html

I think Wilco's patch is reasonable. A potentially simpler alternative
to just restore bootstrap is to take only the second hunk of my patch
above (i.e. without removal of autopref_rank_data and associated cleanups).

FWIW in the previous thread for a closely related issue I Cc'ed Maxim and
Kyrill: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01229.html

Alexander

Follow-Ups:
- Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Ramana Radhakrishnan

References:
- [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Wilco Dijkstra
- Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Christophe Lyon
- Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Wilco Dijkstra
- Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Richard Sandiford
- Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
  - From: Ramana Radhakrishnan

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]