This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output
Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
> Christophe Lyon wrote:
>
>> FWIW, I confirm that this patch fixes the build failure I reported at:
>> https://gcc.gnu.org/ml/gcc-patches/2017-09/msg01980.html
>
> Thanks, now committed as r253399.
I don't think it's reasonable to commit this as obvious. You said
yourself in the covering message that "it doesn't at all restore
the original behaviour since we no longer compare the base address".
So even with the bootstrap failure, I think the patch needed review
before going in.
Christophe's message doesn't change anything because you knew when you
posted the patch that it fixed the failure.
Richard