This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/3] diagnose attribute aligned conflicts (PR 81566)
- From: Jeff Law <law at redhat dot com>
- To: Martin Sebor <msebor at gmail dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 2 Oct 2017 16:27:56 -0600
- Subject: Re: [PATCH 3/3] diagnose attribute aligned conflicts (PR 81566)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 367BD461DC
- References: <184eaaaa-bea6-482f-1579-c3e926d130fb@gmail.com>
On 08/08/2017 10:13 AM, Martin Sebor wrote:
> Patch 3 in the series restores the diagnostics for conflicting
> attribute aligned on the same function (this regressed in r192199
> in GCC 4.9), and also makes use of the enhanced infrastructure to
> enhance the detection of the same conflicts on distinct declarations
> of the same function.
>
> Rather than issuing an error for the confluct as was done in GCC 4.8
> I made it a -Wattributes warning. That seems more in line with how
> otherwise syntactically valid attributes are handled elsewhere, and
> it also lets code developed since the regression was introduced to
> temporarily suppress the warning until the problem is conflict is
> corrected.
>
> Martin
>
> gcc-81544-3.diff
>
>
> PR c/81566 - invalid attribute aligned accepted on functions
>
> gcc/c-family/ChangeLog:
>
> PR c/81566
> c-attribs.c (handle_aligned_attribute): Diagnose conflicting
> attribute specifications.
>
> gcc/testsuite/ChangeLog:
>
> PR c/8166
> * c-c++-common/Wattributes-2.c: New test.
OK.
jeff