This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: sellcey at cavium dot com, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Cc: nd at arm dot com
- Date: Mon, 02 Oct 2017 15:38:00 +0100
- Subject: Re: [Patch][aarch64] Use IFUNCs to enable LSE instructions in libatomic on aarch64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <1502138666.3962.95.camel@cavium.com> <59A03627.4060106@arm.com> <1503944731.28672.134.camel@cavium.com> <59A54F1C.3010806@arm.com> <1504200277.3182.22.camel@cavium.com> <59CCDD8A.9020703@arm.com> <1506716977.15649.41.camel@cavium.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 29/09/17 21:29, Steve Ellcey wrote:
> On Thu, 2017-09-28 at 12:31 +0100, Szabolcs Nagy wrote:
>>
>> i think this should be improved, see below.
>
> Those were all good suggestions, here is a new patch that incorporates
> the changes. I fixed the IFUNC_OPTIONS argument,
> renamed ARCH_AARCH64_LINUX_LSE, got rid of the auxv references, and
> changed HWCAP_TYPE to IFUNC_RESOLVER_ARGS.
>
> Here is the new patch, tested with no regressions.
>
looks good to me, but i cannot approve.
(this will make libatomic depend on ifuncs on aarch64*-linux-gnu.)
> Steve Ellcey
> sellcey@cavium.com
>
>
> 2017-09-29 Steve Ellcey <sellcey@cavium.com>
>
> * Makefile.am (ARCH_AARCH64_LINUX): Add IFUNC_OPTIONS and
> libatomic_la_LIBADD.
> * config/linux/aarch64/host-config.h: New file.
> * configure.ac (IFUNC_RESOLVER_ARGS): Define.
> (ARCH_AARCH64_LINUX): New conditional for IFUNC builds.
> * configure.tgt (aarch64): Set ARCH and try_ifunc.
> (aarch64*-*-linux*) Update config_path.
> (aarch64*-*-linux*) Set IFUNC_RESOLVER_ARGS.
> * libatomic_i.h (GEN_SELECTOR): Add IFUNC_RESOLVER_ARGS argument.
> * Makefile.in: Regenerate.
> * auto-config.h.in: Regenerate.
> * configure: Regenerate.
>