This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [reviewed] qsort comparator consistency checking
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: sellcey at cavium dot com
- Cc: Alexander Monakov <amonakov at ispras dot ru>, Andrew Pinski <pinskia at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 29 Sep 2017 21:43:17 +0200
- Subject: Re: [reviewed] qsort comparator consistency checking
- Authentication-results: sourceware.org; auth=none
- References: <alpine.LNX.2.20.13.1709292109060.18755@monopod.intra.ispras.ru> <1506713976.15649.35.camel@cavium.com>
On 29 September 2017 at 21:39, Steve Ellcey <sellcey@cavium.com> wrote:
> On Fri, 2017-09-29 at 21:14 +0300, Alexander Monakov wrote:
>> On Fri, 29 Sep 2017, Andrew Pinski wrote:
>> >
>> > >
>> > > This patch (r253295) breaks the gcc build for aarch64-linux-gnu:
>> > I was just about to report the same thing.
>> I think autoprefetch ranking heuristic is still wrong if
>> multi_mem_insn_p
>> may be true; please try this patch.
>>
>> * haifa-sched.c (autopref_rank_data): Remove.
>> (autopref_rank_for_schedule): Only use min_offset difference.
>
> This fixed the build for me on aarch64. I am still running the
> testsuite.
>
It doesn't for me. I'm getting another build error:
/home/christophe.lyon/src/GCC/sources/gcc-fsf/aarch64-build/gcc/haifa-sched.c:
In function ‘int autopref_multipass_dfa_lookahead_guard_1(const
rtx_insn*, const rtx_insn*, int)’:
/home/christophe.lyon/src/GCC/sources/gcc-fsf/aarch64-build/gcc/haifa-sched.c:5700:42:
error: ‘autopref_rank_data’ was not declared in this scope
The removed autopref_rank_data function is still called by
autopref_multipass_dfa_lookahead_guard_1.
Christophe
> Steve Ellcey
> sellcey@cavium.com