This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR middle-end/82319] Fix ICE in pattern
- From: Richard Biener <rguenther at suse dot de>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: Yuri Gribov <tetra2005 at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Liška <mliska at suse dot cz>
- Date: Wed, 27 Sep 2017 09:56:04 +0200 (CEST)
- Subject: Re: [PR middle-end/82319] Fix ICE in pattern
- Authentication-results: sourceware.org; auth=none
- References: <CAJOtW+40zsNhzQSx89RxUb2J94CSiHXR4MMtFVontQqJQhJ0gQ@mail.gmail.com> <CA+=Sn1n5nspe+gCvFEunjpcxRRmTDu5Lz4+LA07h=QQXVRVAdA@mail.gmail.com>
On Tue, 26 Sep 2017, Andrew Pinski wrote:
> On Tue, Sep 26, 2017 at 10:56 PM, Yuri Gribov <tetra2005@gmail.com> wrote:
> > Hi all,
> >
> > This patch fixes a trivial ICE in recent pattern. Bootstrapped and
> > regtested on x86_64.
> >
> > Ok to commit?
Ok.
> >+ bool cst_int_p = ! real_isnan (cst) && real_identical (&icst, cst);
>
> The GCC coding style says no space between the ! and the expression.
Does it? I thought it says the opposite.
Richard.
> Note for clarity I would put () around !real_isnan (cst) though.
> Other than that I don't see anything wrong with the patch (I cannot
> approve the patch though).
>
> Thanks,
> Andrew
>
> >
> > -Y
>
>
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)