This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2,rs6000] Replace swap of a loaded vector constant with load of a swapped vector constant
- From: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: Kelvin Nilsen <kdnilsen at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 26 Sep 2017 10:51:08 -0500
- Subject: Re: [PATCH v2,rs6000] Replace swap of a loaded vector constant with load of a swapped vector constant
- Authentication-results: sourceware.org; auth=none
- References: <704420b9-7c98-3dc9-8f3f-37ee056eac46@linux.vnet.ibm.com> <20170926105736.GY8421@gate.crashing.org>
On Sep 26, 2017, at 5:57 AM, Segher Boessenkool <segher@kernel.crashing.org> wrote:
>
>> +/* { dg-final { scan-assembler-not "swap" } } */
>
> So what is this really testing for? xxswapd? But a) we never generate
> that, and b) you could use a better regex?
Agreed, this looks like an unnecessary test for now. Changing to "xxswapd"
would future-proof the test in case we ever generated that. Agree with
Segher that it would be much better to have the tests have uniform naming.
No further comments from me; looks good.
Bill