This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2,rs6000] Replace swap of a loaded vector constant with load of a swapped vector constant


On Sep 26, 2017, at 5:57 AM, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> 
>> +/* { dg-final { scan-assembler-not "swap" } } */
> 
> So what is this really testing for?  xxswapd?  But a) we never generate
> that, and b) you could use a better regex?

Agreed, this looks like an unnecessary test for now.  Changing to "xxswapd"
would future-proof the test in case we ever generated that.  Agree with 
Segher that it would be much better to have the tests have uniform naming.

No further comments from me; looks good.

Bill


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]