This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] BRIG frontend: request for a global review
- From: Martin Jambor <mjambor at suse dot cz>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Pekka Jääskeläinen <pekka at parmance dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Malcolm <dmalcolm at redhat dot com>
- Date: Tue, 26 Sep 2017 14:55:00 +0200
- Subject: Re: [PATCH] BRIG frontend: request for a global review
- Authentication-results: sourceware.org; auth=none
- References: <20170116090746.GM1867@tucnak> <CAJk11WBNMcsLKkzX+GbovsDHq7mDQ0Ehxi_dBVcn9FjUCGY9eg@mail.gmail.com> <CAFiYyc2czhyGBqH5cRLX8otgGkDuJin_-bKsUq9vWaX003mNag@mail.gmail.com> <CAJk11WBpEyWmnSA9Nk3N48gnqwEecNYnNixeaLBX9Az4Hj=AAw@mail.gmail.com> <CAFiYyc1coXT531VGZ7R=2T8NjcVSGGK2Q4w6fmD5Xbpy-B=brA@mail.gmail.com> <20170123120240.h6kannl7ygryurbj@virgil.suse.cz> <CAFiYyc3Erp84wu=GR5VCZ4PLVQN3DY48id4+PubmhL-13PPwFw@mail.gmail.com> <20170124125210.q4red46xdpzechx7@virgil.suse.cz> <1485289834.20340.190.camel@redhat.com> <878thd1q1d.fsf@euler.schwinge.homeip.net>
Hi,
On Sun, Sep 17, 2017 at 02:13:34PM +0200, Thomas Schwinge wrote:
> Hi!
>
> On Tue, 24 Jan 2017 15:30:34 -0500, David Malcolm <dmalcolm@redhat.com> wrote:
> > On Tue, 2017-01-24 at 13:52 +0100, Martin Jambor wrote:
> > > [...] I have just
> > > committed the BRIG FE as revision 244867.
>
> In a build with that enabled, I just happened to "make html" in "gcc/",
> and ran into:
>
> [...]
> makeinfo --split-size=5000000 --html -I [...]/source-gcc/gcc/doc -I [...]/source-gcc/gcc/doc/include \
> -I [...]/source-gcc/gcc/brig -o [...]/build-gcc/gcc/HTML/gcc-8.0.0/brig
> makeinfo: missing file argument.
> Try `makeinfo --help' for more information.
> [...]/source-gcc/gcc/brig/Make-lang.in:117: recipe for target '[...]/build-gcc/gcc/HTML/gcc-8.0.0/brig/index.html' failed
> make: *** [[...]/build-gcc/gcc/HTML/gcc-8.0.0/brig/index.html] Error 255
>
> > A deps issue for the docs I noticed when glancing through the commit:
> >
> > diff --git a/gcc/brig/Make-lang.in b/gcc/brig/Make-lang.in
> > new file mode 100644 (file)
> > index 0000000..b85b1b0
> > --- /dev/null
> > +++ b/gcc/brig/Make-lang.in
> >
> > [...snip...]
> >
> > +# Documentation.
> > +
> > +GO_TEXI_FILES = \
> > + brig/gccbrig.texi \
> > + $(gcc_docdir)/include/fdl.texi \
> > + $(gcc_docdir)/include/gpl_v3.texi \
> > + $(gcc_docdir)/include/gcc-common.texi \
> > + gcc-vers.texi
> >
> > Presumably this should be BRIG_TEXI_FILES, rather than GO_TEXI_FILES?
> >
> > +# doc/gccbrig.info: $(BRIG_TEXI_FILES)
> > +# if test "x$(BUILD_INFO)" = xinfo; then \
> > +# rm -f doc/gccbrig.info*; \
> > +# $(MAKEINFO) $(MAKEINFOFLAGS) -I $(gcc_docdir) \
> > +# -I $(gcc_docdir)/include -o $@ $<; \
> > +# else true; fi
> > +
> > +# doc/gccbrig.dvi: $(BRIG_TEXI_FILES)
> > +# $(TEXI2DVI) -I $(abs_docdir) -I $(abs_docdir)/include -o $@ $<
> > +
> > +# doc/gccbrig.pdf: $(BRIG_TEXI_FILES)
> > +# $(TEXI2PDF) -I $(abs_docdir) -I $(abs_docdir)/include -o $@ $<
> > +
> > +$(build_htmldir)/brig/index.html: $(BRIG_TEXI_FILES)
> > + $(mkinstalldirs) $(@D)
> > + rm -f $(@D)/*
> > + $(TEXI2HTML) -I $(gcc_docdir) -I $(gcc_docdir)/include \
> > + -I $(srcdir)/brig -o $(@D) $<
> >
> > ...for use in describing the deps of the above.
>
> ..., so that still needs to be fixed. Alas, that won't help: the
> "gccbrig.texi" file doesn't actually exist. ;-)
>
I see, I always only check "make info" when verifying documentation
changes and so missed this. Thanks for providing the interim fix, me
and/or Pekka will add some basic content by the time next gcc 7 is
released (IIRC, it is supposed to come out at the end of this or the
beginning of next year).
Martin