Re: [PATCH] PR target/80556

[Mike Stump <mikestump at comcast dot net>]

On Sep 22, 2017, at 2:55 AM, Iain Sandoe <iain@codesourcery.com> wrote:
> 
>> On 18 Sep 2017, at 22:08, Simon Wright <simon@pushface.org> wrote:
>> 
>> On 18 Sep 2017, at 21:09, Iain Sandoe <iain@codesourcery.com> wrote:
>>> 
> 
>>>> If I propose this alternative patch, should it be a new post, or should I continue this thread?
>>> 
>>> thanks for the patch.
>>> 
>>> The basic idea seems sound - as a workaround (as noted in comment #20 in the PR, we should really rationalise the libgcc/crts stuff to reflect the modern world, but these things take time...).
>>> 
>>> The patch as you have it would apply to every version of Darwin.
>>> 
>>> AFAICT from the published sources, i386 Darwin should be able to work with the libgcc unwinder (and all earlier Darwin *have* to) - so I’ve proposed a modified patch in the PR that makes the changes specific to m64 x86 and doesn’t make any alteration for PPC and/or Darwin < 10.
>> 
>> That sounds like the right thing to do. I hadn't considered the older hardware/os issues (I only have kit back to macOS 10.11, Darwin 15).
> 
> So here’s the revised version with the comments slightly updated, checked Darwin10,15,16 x86_64 and i386 in progress,
> OK if i386 succeeds?

Ok.

Attachment: smime.p7s
Description: S/MIME cryptographic signature