Re: [PATCH PR82163/V2]New interface checking LCSSA for single loop

[Richard Biener <richard dot guenther at gmail dot com>]

On Fri, Sep 22, 2017 at 1:37 PM, Bin Cheng <Bin.Cheng@arm.com> wrote:
> Hi,
> This is the V2 patch fixing PR82163.  It rewrites verify_loop_closed_ssa by checking
> uses of all definitions inside of loop.  This gives advantage that we can check loop
> closed ssa form for a specific loop, rather than for whole function.  The interface
> is used in fixing this issue.
> Bootstrap and test on x86_64, is it OK?

Looks good to me.

Thanks,
Richard.

> Thanks,
> bin
> 2017-09-21  Bin Cheng  <bin.cheng@arm.com>
>
>         PR tree-optimization/82163
>         * tree-ssa-loop-manip.h (verify_loop_closed_ssa): New parameter.
>         (checking_verify_loop_closed_ssa): New parameter.
>         * tree-ssa-loop-manip.c (check_loop_closed_ssa_use): Delete.
>         (check_loop_closed_ssa_stmt): Delete.
>         (check_loop_closed_ssa_def, check_loop_closed_ssa_bb): New functions.
>         (verify_loop_closed_ssa): Check loop closed ssa form for LOOP.
>         (tree_transform_and_unroll_loop): Check loop closed ssa form only for
>         changed loops.
>
> gcc/testsuite
> 2017-09-21  Bin Cheng  <bin.cheng@arm.com>
>
>         PR tree-optimization/82163
>         * gcc.dg/tree-ssa/pr82163.c: New test.