This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GRAPHITE] Fix PR71351
- From: Sebastian Pop <sebpop at gmail dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 21 Sep 2017 08:43:10 -0500
- Subject: Re: [PATCH][GRAPHITE] Fix PR71351
- Authentication-results: sourceware.org; auth=none
- References: <alpine.LSU.2.20.1709211204180.26836@zhemvz.fhfr.qr>
On Thu, Sep 21, 2017 at 5:07 AM, Richard Biener <rguenther@suse.de> wrote:
>
> This PR is about code generation issues with us inserting "loop header
> copies" in the attempt to cover up cases where the loop doesn't run.
> But we are disregarding such cases early already. Thus the simple
> fix is to not emit those - we have no idea what values to use
> for reduction results anyway.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
>
> 2017-09-21 Richard Biener <rguenther@suse.de>
>
> PR tree-optimization/71351
> * graphite-isl-ast-to-gimple.c (translate_isl_ast_to_gimple::
> graphite_create_new_loop_guard): Remove, fold remaining parts
> into caller ...
> (translate_isl_ast_node_for): ... here and simplify.
>
> * gfortran.dg/graphite/pr71351.f90: New testcase.
> * gfortran.dg/graphite/interchange-3.f90: Adjust.
>
>
Looks good to me.
Thanks,
Sebastian