This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Backport fix: [PATCH] Fix target attribute handling (PR c++/81355).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 18 Sep 2017 15:05:52 +0200
- Subject: Re: Backport fix: [PATCH] Fix target attribute handling (PR c++/81355).
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jakub at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 57FE55F7BF
- References: <b1cece8b-4522-f539-1b31-7f9da596f862@suse.cz> <ae52342d-5618-bf98-9661-5bcf4a18d8ed@suse.cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Sep 18, 2017 at 03:01:53PM +0200, Martin Liška wrote:
> As discussed here:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81224
>
> We have fallout caused by the patch and it's backport to active branches.
> I'm planning to revert the patch and install patch that will ignore empty string
> values. I'm testing the patch.
>
> Jakub do we really want it also for GCC 7? Note that the problematic test-case is OK on GCC 7 branch
> as it contains your patch mentioned in discussion.
The question is, has the GCC 7 patch changed solely testcases where we'd
ICE on into ones where we warn, or are there cases where we used to accept
it and now warn?
Generally we don't want to introduce new warnings/errors on release branches
on something that used to be accepted, unless really necessary.
Jakub