This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix GIMPLE FE test (PR testsuite/82114)
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Andrew Pinski <pinskia at gmail dot com>
- Date: Tue, 12 Sep 2017 08:29:47 -0400
- Subject: Re: [PATCH] Fix GIMPLE FE test (PR testsuite/82114)
- Authentication-results: sourceware.org; auth=none
- References: <93de6075-90de-7027-bb9e-bafca9f7b89f@suse.cz>
I'm going to abuse either my *gimpl* maintainer hat or my obvious hat
and approve this.
However, since we already have another test that looks the same
(gimplefe-error-2.c) but without the 0 case, it would probably be best
to add a comment in gimplefe-14.c as to why there is a 0 case. In the
case of gimplefe-error-2.c, it doesn't matter because it is only a
compile test.
OK with that nit.
On Tue, Sep 12, 2017 at 3:44 AM, Martin Liška <mliska@suse.cz> wrote:
> Hello.
>
> Simple fix for args == 0 also returns 0 return value.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready to be installed?
> Martin
>
> gcc/testsuite/ChangeLog:
>
> 2017-09-11 Martin Liska <mliska@suse.cz>
>
> PR testsuite/82114
> * gcc.dg/gimplefe-14.c (main): Add handling of case 0.
> ---
> gcc/testsuite/gcc.dg/gimplefe-14.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>