This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)
- From: Jason Merrill <jason at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Marek Polacek <polacek at redhat dot com>, Jonathan Wakely <jwakely at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Sat, 9 Sep 2017 15:42:35 +0200
- Subject: Re: [PATCH] Improve -Ofast vectorization of std::sin etc. (PR libstdc++/81706)
- Authentication-results: sourceware.org; auth=none
- References: <20170807090825.GK2123@tucnak> <d8d629b2-86f6-9c1f-f627-814f73274fd1@redhat.com> <20170807152742.GM2123@tucnak> <20170901111249.GD2323@tucnak>
On Fri, Sep 1, 2017 at 1:12 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> + tree s = lookup_attribute ("omp declare simd",
> + DECL_ATTRIBUTES (newdecl));
> + if (s)
> + {
> + tree b
> + = builtin_decl_explicit (DECL_FUNCTION_CODE (newdecl));
> + if (b)
> + duplicate_one_attribute (&DECL_ATTRIBUTES (b), s,
> + "omp declare simd");
> + }
Is there a reason not to set b first and move the lookup of s into the
function as well?
Jason