This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN
- From: Ian Lance Taylor <iant at golang dot org>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 9 Sep 2017 05:27:39 -0700
- Subject: Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN
- Authentication-results: sourceware.org; auth=none
- References: <1500456645-30359-1-git-send-email-yao.qi@linaro.org> <20170726085510.GA8039@1170ee0b50d5> <CAH=s-POK+LNJLCo8LrMRBJmDyhrGFxsCL-XDGajJfevFn5MSOw@mail.gmail.com> <b6d3391f-5f0b-501e-551e-e03160076c18@redhat.com> <CAH=s-PM5x-L0vmBak7sO6tDYJyTSy0Lghn8jwKO3S0mgrnzTaA@mail.gmail.com>
On Sat, Sep 9, 2017 at 2:45 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Fri, Aug 11, 2017 at 3:14 PM, Pedro Alves
>> Yeah, this is a macro that lots of projects out there reinvent,
>> can't imagine it being very controversial.
>>
>> I could have used this today in another spot in gdb.
>>
>> The patch as is touches areas with different maintainers, it
>> may have fallen victim of diffusion of responsibility.
>>
>> Could we get at least the ansidecl.h change in, so we can
>> start using it in gdb? CCing Ian as a libiberty maintainer.
>
> Hi Ian,
> I just talked with you about this patch. You are cc'ed. Could you
> take a look at the change in include/ansidecl.h? Then, we can use it
> in different
> projects, gcc, gdb and gold.
The patch to include/ansidecl.h is basically OK. Please add an
example in the comment showing how to use it: after `private:`, and
with a trailing semicolon. Thanks.
The patches to the other files will have to be approved by the
relevant maintainers.
Ian