This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2, middle-end]: Introduce memory_blockage named insn pattern
- From: Alexander Monakov <amonakov at ispras dot ru>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
- Date: Tue, 5 Sep 2017 17:22:22 +0300 (MSK)
- Subject: Re: [PATCH v2, middle-end]: Introduce memory_blockage named insn pattern
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4Z9F8J3+hDM51fsjHcQ7XPrwdj4Geoyd53Nf4JKS+szYQ@mail.gmail.com>
On Tue, 5 Sep 2017, Uros Bizjak wrote:
> Revised patch, incorporates fixes from Alexander's review comments.
>
> I removed some implementation details from Alexander's description of
> memory_blockage named pattern.
Well, to me it wasn't really obvious why a named pattern was needed
in the first place, so I wish the explanation could stay in some form.
One small nit, the new function comment in optabs.c,
+/* Do not propagate memory accesses across this point. */
doesn't seem appropriate, it should probably say something like
/* Emit an insn acting as a compiler memory barrier. */
Rest of the patch looks fine to me (but I cannot approve it).
Thanks.
Alexander