This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [06/77] Make GET_MODE_WIDER return an opt_mode
- From: Jeff Law <law at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at linaro dot org
- Date: Mon, 28 Aug 2017 13:11:24 -0600
- Subject: Re: [06/77] Make GET_MODE_WIDER return an opt_mode
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0431A8046E
- References: <8760ewohsv.fsf@linaro.org> <87fue0n317.fsf@linaro.org> <9b296653-5505-8a64-bdde-9ee879f7363e@redhat.com> <87poc2q7xr.fsf@linaro.org> <487e855f-3202-c562-83dc-112632a62e63@redhat.com> <871snvtsvk.fsf@linaro.org>
On 08/28/2017 01:05 PM, Richard Sandiford wrote:
>
>> As for the name, get_nonvoid? Ugh. Not sure. Open to suggestions.
>
> I'd rather avoid "nonvoid", since the use of VOIDmode for "no mode" is
> really an implementation detail in things like opt_mode <scalar_int_mode>.
> Other possiblities might be:
Yea, good point on encoding the implementation detail not being a good idea.
>
> - require
> - demand
> - mode
> - get_mode
> - require_mode
> - demand_mode
> - else_fail (to go with else_void and else_blk)
> - noelse
require, demand with or without the _mode suffix seem good to me.
jeff