This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 0003-Part-3.-Add-tests-for-finstrument-control-flow-and-notrack attribute
- From: Jeff Law <law at redhat dot com>
- To: "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>, "'gcc-patches at gcc dot gnu dot org'" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 25 Aug 2017 15:01:13 -0600
- Subject: Re: 0003-Part-3.-Add-tests-for-finstrument-control-flow-and-notrack attribute
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 36D53C04B94A
- References: <D511F25789BA7F4EBA64C8A63891A0027AA0404B@IRSMSX102.ger.corp.intel.com>
On 08/01/2017 02:56 AM, Tsimbalist, Igor V wrote:
> Part#3. Add tests for -finstrument-control-flow and notrack attribute.
>
>
> 0003-Part-3.-Add-tests-for-finstrument-control-flow-and-n.patch
>
>
> From 7869de8a0c0ec55c4e9240c2483fefee97bf34c9 Mon Sep 17 00:00:00 2001
> From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
> Date: Mon, 3 Jul 2017 17:29:08 +0300
> Subject: [PATCH 3/9] Part#3. Add tests for -finstrument-control-flow and
> notrack attribute.
>
> gcc/testsuite/
>
> * c-c++-common/finstrument-control-flow.c: New test.
> * c-c++-common/notrack-1.c: Likewise.
> * c-c++-common/notrack-2.c: Likewise.
No concerns with the existing tests.
We should consider an ICF test as I outlined in an earlier message.
We should also consider tests where we drop/add the notrack attribute as
ISTM we ought to be getting warnings in those cases.
Finally, you should consider tests in gcc.target/i386 that verify we
generate the proper instrumentation for a few tests.
jeff