This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2][PING][PR 59521] Respect __builtin_expect in switch statements


On 07/27/2017 09:21 PM, Yury Gribov wrote:
> Hi all,
> 
> This is a ping for
> https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01275.html . I've fixed
> attachment type, hopefully it's easier to read now.
> 
> This patch adds support for __builtin_expect in switch statements at
> tree level (RTL part would be reviewed/commited separately).  It's an
> update of https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01016.html ,
> rebased and retested.
> 
> Ok for trunk?
> 
> -Y
> 
> pr59521-2.patch
> 
> 
> 2017-07-21  Yury Gribov  <tetra2005@gmail.com>
> 	    Martin Liska  <marxin@gcc.gnu.org>
> 
> 	PR middle-end/59521
> 
> gcc/
> 	* predict.c (set_even_probabilities): Handle case of a single
> 	likely edge.
> 	(combine_predictions_for_bb): Ditto.
> 	(tree_predict_by_opcode): Handle switch statements.
> 	* stmt.c (balance_case_nodes): Select pivot value based on
> 	probabilities.
> 
> gcc/testsuite/
> 	* gcc.dg/predict-15.c: New test.
Your patch includes changes to tree-cfg.c.  Those need to be mentioned
in the ChangeLog.

Your ChangeLog entry mentions a stmt.c change, but there is no such
change in the patch itself.

The bits that are actually in the patch are fine.  You just need to
verify they're what you wanted to submit, and if so make sure they have
a correct ChangeLog and they're OK.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]