This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] [MSP430] Read mcu data from file instead of hardcoded data
- From: DJ Delorie <dj at redhat dot com>
- To: Jozef Lawrynowicz <jozef dot l at somniumtech dot com>
- Cc: gcc-patches at gcc dot gnu dot org, nickc at redhat dot com
- Date: Thu, 24 Aug 2017 12:27:36 -0400
- Subject: Re: [PATCH] [MSP430] Read mcu data from file instead of hardcoded data
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 731783E6
Back when we first designed this, I asked about including devices.csv in
the gcc sources, and... no. It's not GPL. So please make sure to
thoroughly test the "no devices.csv found" case. It's fine to use it to
override the internal data, but not fine to rely on it.
> * gcc/config/msp430/msp430.h: Don't pass -mmcu to the assembler.
Does this break compatibility with older versions of binutils?
> +/* This structure is no longer being maintained. Up-to-date data is read from
> + a devices.csv file on the user's system.
I think occasional updates to the table are still warranted from a
philosophical and GPL point of view, although I expect the average user
to use the latest devices.csv anyway. If gcc stops working properly for
lack of a proprietary file, that's a problem.
[rest of review later]