This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS

From: Mike Stump <mikestump at comcast dot net>
To: Daniel Santos <daniel dot santos at pobox dot com>
Cc: Martin Sebor <msebor at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Sandra Loosemore <sandra at codesourcery dot com>, Gerald Pfeifer <gerald at pfeifer dot com>, Joseph Myers <joseph at codesourcery dot com>, Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
Date: Tue, 22 Aug 2017 12:38:45 -0700
Subject: Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS
Authentication-results: sourceware.org; auth=none
References: <20170822014151.5431-1-daniel.santos@pobox.com> <5fcb52ce-8fdc-22d0-06b9-e7f7fc2d222e@gmail.com> <06c7aeb4-4552-aa16-a1b5-d2d5b9be5873@pobox.com> <97583547-2921-46FE-8B2B-1B4660B645D3@comcast.net> <95254df2-bb10-0e0b-16b4-72428ac24e05@pobox.com>

On Aug 22, 2017, at 11:53 AM, Daniel Santos <daniel.santos@pobox.com> wrote:
> 
> OK, the problem is at line 4014 of gcc/Makefile.in:
> 
>          $(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)"
> RUNTESTFLAGS="$(RUNTESTFLAGS)" \
>            check-parallel-$* \

So, this is typical of sh scripting.  Most kids don't quote and know how to quote in other than trivial cases.  It is one of the reasons why scripting is both better and worse.  sh from day 1 should have had a quote function that would quote the operand, it doesn't.  If it did, we'd put $(quote ...) in there instead of "..." and it would just work.

> I presume that the solution would be to re-escape the contents of
> RUNTESTFLAGS.

Yes.  The annoyance factor is so high, that no one ever does.  Feel free rot ignore the problem.

References:
- [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS
  - From: Daniel Santos
- Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS
  - From: Martin Sebor
- Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS
  - From: Daniel Santos
- Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS
  - From: Mike Stump
- Re: [PATCH] [docs] Explain how to use multiple file-name patterns in RUNTESTFLAGS
  - From: Daniel Santos

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]