This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] 3/3 Add x86 SSE <xmmintrin.h> intrinsics to GCC PPC64LE taget
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Steven Munroe <munroesj at linux dot vnet dot ibm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Fri, 18 Aug 2017 19:03:53 -0500
- Subject: Re: [PATCH, rs6000] 3/3 Add x86 SSE <xmmintrin.h> intrinsics to GCC PPC64LE taget
- Authentication-results: sourceware.org; auth=none
- References: <1502916655.16102.72.camel@oc7878010663> <20170817054714.GI13471@gate.crashing.org> <1503092984.16603.7.camel@oc7878010663>
On Fri, Aug 18, 2017 at 04:49:44PM -0500, Steven Munroe wrote:
> On Thu, 2017-08-17 at 00:47 -0500, Segher Boessenkool wrote:
> > On Wed, Aug 16, 2017 at 03:50:55PM -0500, Steven Munroe wrote:
> > > This it part 3/3 for contributing PPC64LE support for X86 SSE
> > > instrisics. This patch includes testsuite/gcc.target tests for the
> > > intrinsics included by xmmintrin.h.
> >
> > > +#define CHECK_EXP(UINON_TYPE, VALUE_TYPE, FMT) \
> >
> > Should that be UNION_TYPE?
>
> It is spelled 'UINON_TYPE' in
> ./gcc/testsuite/gcc.target/i386/m128-check.h which the source for the
> powerpc version.
>
> There is no obvious reason why it could not be spelled UNION_TYPE.
> Unless there is some symbol collision further up the SSE/AVX stack.
>
> Bingo:
>
> avx512f-helper.h:#define UNION_TYPE(SIZE, NAME) EVAL(union, SIZE, NAME)
>
> I propose not to change this.
Heh. Okay :-)
Segher