This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] testcase coverage for vec_perm built-ins


On Thu, Aug 17, 2017 at 09:19:17AM -0500, Will Schmidt wrote:
> Add testcase coverage for the vec_ld intrinsic builtins.
> 
> Tested across power platforms (p6 and newer). OK for trunk?

> 	* gcc.target/powerpc/fold-vec-ld-char.c: New.
> 	* gcc.target/powerpc/fold-vec-ld-double.c: New.
> 	* gcc.target/powerpc/fold-vec-ld-float.c: New.
> 	* gcc.target/powerpc/fold-vec-ld-int.c: New.
> 	* gcc.target/powerpc/fold-vec-ld-longlong.c: New.
> 	* gcc.target/powerpc/fold-vec-ld-short.c: New.

> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-ld-float.c
> @@ -0,0 +1,23 @@
> +/* Verify that overloaded built-ins for vec_ld with float
> +   inputs produce the right results.  */
> +
> +/* { dg-do compile } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
> +/* { dg-options "-maltivec -O2" } */

This is vsx_ok but you're only using -maltivec?  Should it use
altivec_ok instead?

> @@ -0,0 +1,28 @@
> +/* Verify that overloaded built-ins for vec_ld* with long long
> +   inputs produce the right results.  */
> +
> +/* { dg-do compile { target lp64 } } */
> +/* { dg-require-effective-target powerpc_p8vector_ok } */
> +/* { dg-options "-mvsx -mpower8-vector -O2" } */

-mvsx is redundant with -mpower8-vector; remove -mvsx?

Okay for trunk with those two things taken care of.  Thanks,


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]