This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Libgomp, Fortran] Fix canadian cross build
- From: Yvan Roux <yvan dot roux at linaro dot org>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Paolo Bonzini <bonzini at gnu dot org>
- Date: Fri, 18 Aug 2017 10:27:21 +0200
- Subject: Re: [Libgomp, Fortran] Fix canadian cross build
- Authentication-results: sourceware.org; auth=none
- References: <CAD57uCd01sx_Swz7Xs=fjKde+2sFRTWA6SqbZLdC+SuYWw=Z0w@mail.gmail.com> <CAD57uCd6OuQ-qXMGx5rOaY+jvsHw4si2ECbDCsMG0jbh0BOpcQ@mail.gmail.com> <CAD57uCe59=FO1rTkc4uEE+yb5UpBUw+v7-ovQ7DXaOzSTyKnNw@mail.gmail.com> <CAD57uCcKHXJ=FN0P2VvtE=GDwmgQAoBVbWcXpe9b6pxHQKSKNg@mail.gmail.com>
On 4 August 2017 at 15:52, Yvan Roux <yvan.roux@linaro.org> wrote:
> On 11 July 2017 at 12:25, Yvan Roux <yvan.roux@linaro.org> wrote:
>> On 3 July 2017 at 11:21, Yvan Roux <yvan.roux@linaro.org> wrote:
>>> On 23 June 2017 at 15:44, Yvan Roux <yvan.roux@linaro.org> wrote:
>>>> Hello,
>>>>
>>>> Fortran parts of libgomp (omp_lib.mod, openacc.mod, etc...) are
>>>> missing in a canadian cross build, at least when target gfortran
>>>> compiler comes from PATH and not from GFORTRAN_FOR_TARGET.
>>>>
>>>> Back in 2010, executability test of GFORTRAN was added to fix libgomp
>>>> build on cygwin, but when the executable doesn't contain the path,
>>>> "test -x" fails and part of the library are not built.
>>>>
>>>> This patch fixes the issue by using M4 macro AC_PATH_PROG (which
>>>> returns the absolute name) instead of AC_CHECK_PROG in the function
>>>> defined in config/acx.m4: NCN_STRICT_CHECK_TARGET_TOOLS. I renamed it
>>>> into NCN_STRICT_PATH_TARGET_TOOLS to keep the semantic used in M4.
>>>>
>>>> Tested by building cross and candian cross toolchain (host:
>>>> i686-w64-mingw32) for arm-linux-gnueabihf with issue and with a
>>>> complete libgomp.
>>>>
>>>> ok for trunk ?
>>>
>>> ping?
>>
>> ping?
>
> ping
ping
https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01784.html
>>>
>>>> Thanks
>>>> Yvan
>>>>
>>>> config/ChangeLog
>>>> 2017-06-23 Yvan Roux <yvan.roux@linaro.org>
>>>>
>>>> * acx.m4 (NCN_STRICT_CHECK_TARGET_TOOLS): Renamed to ...
>>>> (NCN_STRICT_PATH_TARGET_TOOLS): ... this. It reflects the replacement
>>>> of AC_CHECK_PROG by AC_PATH_PROG to get the absolute name of the
>>>> program.
>>>> (ACX_CHECK_INSTALLED_TARGET_TOOL): Use renamed function.
>>>>
>>>> ChangeLog
>>>> 2017-06-23 Yvan Roux <yvan.roux@linaro.org>
>>>>
>>>> * configure.ac: Use NCN_STRICT_PATH_TARGET_TOOLS instead of
>>>> NCN_STRICT_CHECK_TARGET_TOOLS.
>>>> * configure: Regenerate.