This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] fold-vec testcase fix-ups
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Thu, 10 Aug 2017 08:46:00 -0500
- Subject: Re: [PATCH, rs6000] fold-vec testcase fix-ups
- Authentication-results: sourceware.org; auth=none
- References: <1502371637.6577.48.camel@brimstone.rchland.ibm.com>
On Thu, Aug 10, 2017 at 08:27:17AM -0500, Will Schmidt wrote:
> A testcase coverage issue and an obvious typo fix.
>
> Mostly obvious,.. OK for trunk?
Yes; one comment:
> diff --git a/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c b/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c
> index d8acc3c..73131bb 100644
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-pack-longlong.c
> @@ -1,9 +1,9 @@
> /* Verify that overloaded built-ins for vec_pack with long long
> inputs produce the right results. */
>
> -/* { dg-do compile } */
> +/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
> /* { dg-require-effective-target powerpc_p8vector_ok } */
> /* { dg-options "-mvsx -mpower8-vector -O2" } */
You can just say
/* { dg-do compile { target lp64 } } */
(make sure to test before you commit :-) )
Segher