This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Clean up capitalized diagnostic messages


On Aug 2, 2017, at 11:04 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> 
> On Wed, 2 Aug 2017, Jakub Jelinek wrote:
> 
>> On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
>>> --- gcc/config/rs6000/rs6000.c	(revision 250791)
>>> +++ gcc/config/rs6000/rs6000.c	(working copy)
>>> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>>>       || rs6000_cpu == PROCESSOR_PPCE5500)
>>>     {
>>>       if (TARGET_ALTIVEC)
>>> -	error ("AltiVec not supported in this target");
>>> +	error ("altivec not supported in this target");
>> 
>> If AltiVec is spelled that way always, then I think we want to keep it
>> capitalized, but CCing Joseph just to be sure.  Or the diagnostics
> 
> Yes, if it would be capitalized mid-sentence then it should be capitalized 
> at the start of a diagnostic (and if it wouldn't be capitalized 
> mid-sentence, it shouldn't be capitalized at the start of a diagnostic).

Honestly, if I had my way we would retroactively change all the
"altivec/Altivec/AltiVec" inconsistencies to "VMX". ;-)  But given the
ubiquity of <altivec.h> (lowercase there) I suppose that's not practical...

I'll return this one to AltiVec, and change "GCC vector" to "GNU vector"
if that's okay with everyone.

Bill

> 
> -- 
> Joseph S. Myers
> joseph@codesourcery.com
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]