This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
- From: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Segher Boessenkool <segher at kernel dot crashing dot org>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Wed, 2 Aug 2017 13:49:56 -0500
- Subject: Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
- Authentication-results: sourceware.org; auth=none
- References: <9a2980f0-01ed-1474-c4a2-f743695d60f8@linux.vnet.ibm.com> <20170802155511.GL2123@tucnak> <alpine.DEB.2.20.1708021603320.24686@digraph.polyomino.org.uk>
On Aug 2, 2017, at 11:04 AM, Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Wed, 2 Aug 2017, Jakub Jelinek wrote:
>
>> On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
>>> --- gcc/config/rs6000/rs6000.c (revision 250791)
>>> +++ gcc/config/rs6000/rs6000.c (working copy)
>>> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>>> || rs6000_cpu == PROCESSOR_PPCE5500)
>>> {
>>> if (TARGET_ALTIVEC)
>>> - error ("AltiVec not supported in this target");
>>> + error ("altivec not supported in this target");
>>
>> If AltiVec is spelled that way always, then I think we want to keep it
>> capitalized, but CCing Joseph just to be sure. Or the diagnostics
>
> Yes, if it would be capitalized mid-sentence then it should be capitalized
> at the start of a diagnostic (and if it wouldn't be capitalized
> mid-sentence, it shouldn't be capitalized at the start of a diagnostic).
Honestly, if I had my way we would retroactively change all the
"altivec/Altivec/AltiVec" inconsistencies to "VMX". ;-) But given the
ubiquity of <altivec.h> (lowercase there) I suppose that's not practical...
I'll return this one to AltiVec, and change "GCC vector" to "GNU vector"
if that's okay with everyone.
Bill
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
>