This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: c-family PATCH to improve and simplify -Wmultistatement-macros (PR c/81448, c/81306)
- From: Marek Polacek <polacek at redhat dot com>
- To: Steve Ellcey <sellcey at cavium dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Malcolm <dmalcolm at redhat dot com>
- Date: Wed, 2 Aug 2017 19:33:35 +0200
- Subject: Re: c-family PATCH to improve and simplify -Wmultistatement-macros (PR c/81448, c/81306)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=polacek at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8056D8553F
- References: <20170727144420.GK3397@redhat.com> <alpine.DEB.2.20.1708021135150.19718@digraph.polyomino.org.uk> <1501694214.3962.45.camel@cavium.com>
On Wed, Aug 02, 2017 at 10:16:54AM -0700, Steve Ellcey wrote:
> On Wed, 2017-08-02 at 11:37 +0000, Joseph Myers wrote:
> > On Thu, 27 Jul 2017, Marek Polacek wrote:
> >
> > >
> > > Bootstrapped/regtested on x86_64-linux and ppc64le-linux, ok for
> > > trunk?
> > >
> > > 2017-07-27 Marek Polacek <polacek@redhat.com>
> > >
> > > PR c/81448
> > > PR c/81306
> > > * c-warn.c (warn_for_multistatement_macros): Prevent bogus
> > > warnings. Avoid walking MACRO_MAP_LOCATIONS.
> > >
> > >
> > > * c-c++-common/Wmultistatement-macros-13.c: New test.
> > OK. Steve, as I noted in
> > <https://sourceware.org/ml/libc-alpha/2017-07/msg00942.html>, please see
> > if this means you no longer need to use -Wno-multistatement-macros for
> > certain glibc tests (if it's still needed, that suggests another related
> > problem may still be present).
>
> I have built and tested the latest glibc with the latest gcc and after
> removing the warnings from the Makefile, everything ran fine. There
> were no build problems.
Excellent. And sorry for the trouble in the first place.
Marek