This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/5] Replace insn_rtx_cost with insn_cost and pattern_cost
- From: Jeff Law <law at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 2 Aug 2017 10:37:57 -0600
- Subject: Re: [PATCH 2/5] Replace insn_rtx_cost with insn_cost and pattern_cost
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E84EB77542
- References: <cover.1501541006.git.segher@kernel.crashing.org> <751cf47f2e72e48439673d88afdc795a849ba232.1501541007.git.segher@kernel.crashing.org>
On 07/31/2017 05:25 PM, Segher Boessenkool wrote:
> This renames insn_rtx_cost to pattern cost, and adds a new function
> insn_cost that takes an rtx_insn * instead of an instruction pattern
> as input. It uses the latter function anywhere an instruction is
> readily available (instead of just an instruction pattern).
>
> The actual implementation of insn_cost just calls pattern_cost on
> the pattern of the instruction; no functional change yet.
>
> ---
> gcc/cfgrtl.c | 7 +++----
> gcc/combine.c | 17 ++++++++---------
> gcc/dse.c | 2 +-
> gcc/ifcvt.c | 12 ++++++------
> gcc/rtl.h | 3 ++-
> gcc/rtlanal.c | 13 +++++++++++--
> 6 files changed, 31 insertions(+), 23 deletions(-)
Also looks good to me to go in once you've got a ChangeLog.
jeff