This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Rewrite mklog in Python
- From: Jeff Law <law at redhat dot com>
- To: Yury Gribov <tetra2005 dot patches at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Cc: Mike Stump <mikestump at comcast dot net>, Trevor Saunders <tbsaunde at tbsaunde dot org>
- Date: Wed, 2 Aug 2017 10:19:22 -0600
- Subject: Re: [PATCH] Rewrite mklog in Python
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85CBD734C4
- References: <c3d39b27-30fd-0d4b-9b76-932d3ea2cdc3@gmail.com>
On 08/01/2017 01:00 PM, Yury Gribov wrote:
> Hi all,
>
> This is a rewrite of contrib/mklog in Python. I started adding features
> suggested by Trevor some time ago but this quickly turned into a full
> rewrite of existing Perl mklog and then I decided to just fully rewrite
> it in Python (given that this has been requested several times).
>
> The code is mostly similar to existing version, except that I now
> separate parsing and generation of ChangeLog text (for clarity). New
> script will also (try to) detect changes in prototypes, macro and
> supermacro.
>
> I have a local testsuite for mklog which I used to verify functionality.
> In all cases it was similar or better compared to Perl version. And
> I'll obviously be around to fix regressions.
>
> I suggest to replace existing contrib/mklog with this (Perl version can
> be moved to contrib/mklog.pl).
Sounds good to me. Please go ahead and install, keeping the old one
as mklog.pl for now.
Jeff