This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR libstdc++/79162 ambiguity in string assignment due to string_view overload (LWG 2946)
- From: Tim Song <t dot canens dot cpp at gmail dot com>
- To: Daniel Krügler <daniel dot kruegler at gmail dot com>
- Cc: libstdc++ at gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 Jul 2017 16:25:58 -0400
- Subject: Re: [PATCH] PR libstdc++/79162 ambiguity in string assignment due to string_view overload (LWG 2946)
- Authentication-results: sourceware.org; auth=none
- References: <CAGNvRgCv1Y8a6DGO=p9g8FAve1-UKf53vshqFYtdmWkDUzn8+Q@mail.gmail.com>
On Fri, Jul 28, 2017 at 4:10 PM, Daniel Krügler
<daniel.kruegler@gmail.com> wrote:
> + // Performs an implicit conversion from _Tp to __sv_type.
> + template<typename _Tp>
> + static __sv_type _S_to_string_view(const _Tp& __svt)
> + {
> + return __svt;
> + }
I might have gone for
+ static __sv_type _S_to_string_view(__sv_type __svt) noexcept
+ {
+ return __svt;
+ }
With that, we can also use noexcept(_S_to_string_view(__t)) to make up
for the absence of is_nothrow_convertible (basically the same thing I
did in LWG 2993's PR).
Tim