This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, libfortran] Fix PR 80365, undefined memcpy


On Mon, Jul 24, 2017 at 2:12 PM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Janne,
>
>> On Sun, Jul 23, 2017 at 10:23 PM, Thomas Koenig <tkoenig@netcologne.de>
>> wrote:
>>>
>>> Hello world,
>>>
>>> the attached test cases fixes a problematic invocation of
>>> memcpy where src=NULL and n=0 by simply doing nothing
>>> in the surrounding function if there is nothing to be done.
>>>
>>> No test case, because this only shows up with a sanitized
>>> libgfortran or under a debugger.
>>>
>>> OK for trunk?
>>
>>
>> Good catch, Ok.
>
>
>
> Committed, thanks for the review.
>
> What is the opinion on backporting?  We should avoid undefined
> behavior in the library, I think, so I am leanding towards
> doing it.
>
> Regards
>
>         Thomas
>

Sure, go ahead. I can't see how the patch would cause any bugs (knock
knock...), so it seems quite safe.

BTW, there might be a similar issue in buf_read()?


-- 
Janne Blomqvist


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]