This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 00/19] cleanup of memory stats prototypes
On 27 July 2017 10:43:09 CEST, Richard Biener <richard.guenther@gmail.com> wrote:
>On Thu, Jul 27, 2017 at 10:30 AM, <tbsaunde+gcc@tbsaunde.org> wrote:
>> From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
>>
>> The preC++ way of passing information about the call site of a
>function was to
>> use a macro that passed __file__, __LINE__, and __FUNCTION__ to a
>function with
>> the same name with _stat appended to it. The way this is now done
>with C++ is
>> to have arguments where the default value is __LINE__, __FILE__, and
>> __FUNCTION__ in the caller. This has the significant advantage that
>if you
>> look for "^function (" you find the correct function, where in the C
>way of
>> doing things you need to realize its a macro and check the definition
>of the
>> macro to see what to look for next. So this removes a layer of
>indirection,
>> and makes things somewhat more consistant in using the C++ way of
>doing things.
>>
>> patches independently bootstrapped and regtested on
>ppc64le-linux-gnu. I
>> successfully ran make all-gcc with
>--enable-gather-detailed-mem-stats, but
>> couldn't complete a bootstrap before the series was applied, because
>the
>> ddrs_table in tree-loop-distribution.c causes memory statistics
>gathering to crash before the series as well as after it. ok?
>
>Thanks! This was on my list of things todo...
>
>The series is ok.
Maybe s/enum tree_code/tree_code/ in the lines you touch?
Thanks,
>
>Did you catch all of MEM_STAT_INFO/ALONE_MEM_STAT_INFO so we can remove
>the
>non-C++ way from statistics.h?